Conversation
Most notably, add a section about compiling while using rocksdb library provided by the system. Based on my observation, this helps with OOMs. I think (though I haven’t tested it) that rust-rocksdb builds rocksdb library with LTO enabled which consumes bunch of memory. While at it, make some minor fixes to the document. Change ‘bash’ preformatted blocks to ‘console’ where the latter is more appropriate and remove mention of `start_localnet.py` script which no longer exists.
|
Your Render PR Server URL is https://near-docs-pr-1076.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cacn5nr0tnuk4b0e4jo0. |
nagisa
reviewed
Jun 3, 2022
| # time RUSTFLAGS='-C lto=off -C link-arg=-fuse-ld=lld' RUSTC_WRAPPER= cargo build -p neard --release | ||
| ```console | ||
| $ cargo clean | ||
| $ time RUSTFLAGS='-C lto=off -C link-arg=-fuse-ld=lld' RUSTC_WRAPPER= cargo build -p neard --release |
Contributor
There was a problem hiding this comment.
NB: this is going to be shortly made more straightforward via -Clinker-flavor=gcc:lld, with or without -Clink-self-contained=linker. We should keep an action item for that.
nagisa
reviewed
Jun 3, 2022
Contributor
|
largely LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most notably, add a section about compiling while using rocksdb
library provided by the system. Based on my observation, this helps
with OOMs. I think (though I haven’t tested it) that rust-rocksdb
builds rocksdb library with LTO enabled which consumes bunch of
memory.
While at it, make some minor fixes to the document. Change ‘bash’
preformatted blocks to ‘console’ where the latter is more appropriate
and remove mention of
start_localnet.pyscript which no longerexists.
Also add
envto replacetime VAR=foo commandsince the latter onlyworks with some shells which provide
timebuilt-in. Usingenvtoset the environment variables makes it more portable.